an error

random guy · Feb 11, 2006

hey guys, i am new here, and a little new to programming.

i am working on a c++ command line card game and it is going fairly well but i am running into a few problems that i dont know how to fix.

see what i got so far is that a deck of cards is made, shuffled and dealt. then it is player 1's turn to put in a card and then comes 3 computer players. the only rule i got is that to play a new card it must be of a higher value than the center card which was played by the previous person. if the player doesnt have a card higher than the one on top of the pile he can pass. if everyone passes then the centercard is thrown away and any card can be put in its place. the different suites have no significance right now.

my problem is with the AI players. sometimes they play cards that are lower than the card in the center. ex: card on top of pile is a 5 of hearts and the computer player plays a 4 of clubs. it shouldnt but somehow it does.

thanks for the help.

#include <iostream>
#include <stdlib.h>
#include <time.h>

using namespace std;

void deal();
void shuffle();
void board();
void p1turn();
void p2turn();
void p3turn();
void p4turn();
void wincheck1();
void wincheck2();
void wincheck3();
void wincheck4();

string player1[13];
string player2[13];
string player3[13];
string player4[13];
string centercard = "none";

int centerpower=0;
int passer=0;
int powerdeck[52]={2,2,2,2, 3,3,3,3, 4,4,4,4, 5,5,5,5, 6,6,6,6, 7,7,7,7, 8,8,8,8, 9,9,9,9, 10,10,10,10, 11,11,11,11, 12,12,12,12, 13,13,13,13, 14,14,14,14};

string fulldeck[52]=
{"2 OF H", "2 OF S", "2 OF D", "2 OF C", "3 OF H", "3 OF S", "3 OF D", "3 OF C",
"4 OF H", "4 OF S", "4 OF D", "4 OF C", "5 OF H", "5 OF S", "5 OF D", "5 OF C",
"6 OF H", "6 OF S", "6 OF D", "6 OF C", "7 OF H", "7 OF S", "7 OF D", "7 OF C",
"8 OF H", "8 OF S", "8 OF D", "8 OF C", "9 OF H", "9 OF S", "9 OF D", "9 OF C",
"10 OF H", "10 OF S", "10 OF D", "10 OF C", "J OF H", "J OF S", "J OF D", "J OF C",
"Q OF H", "Q OF S", "Q OF D", "Q OF C", "K OF H", "K OF S", "K OF D", "K OF C",
"A OF H", "A OF S", "A OF D", "A OF C"};
string shuffleddeck[52]=
{"2 OF H", "2 OF S", "2 OF D", "2 OF C", "3 OF H", "3 OF S", "3 OF D", "3 OF C",
"4 OF H", "4 OF S", "4 OF D", "4 OF C", "5 OF H", "5 OF S", "5 OF D", "5 OF C",
"6 OF H", "6 OF S", "6 OF D", "6 OF C", "7 OF H", "7 OF S", "7 OF D", "7 OF C",
"8 OF H", "8 OF S", "8 OF D", "8 OF C", "9 OF H", "9 OF S", "9 OF D", "9 OF C",
"10 OF H", "10 OF S", "10 OF D", "10 OF C", "J OF H", "J OF S", "J OF D", "J OF C",
"Q OF H", "Q OF S", "Q OF D", "Q OF C", "K OF H", "K OF S", "K OF D", "K OF C",
"A OF H", "A OF S", "A OF D", "A OF C"};

main()
{

cout << "Welcome! \n" << "This is my card game. \n";
cout << "starting a new game \n" <<"will now shuffle \n";
cin.get();
shuffle();
deal();
board();

}
void shuffle()
{
time_t seconds;
time(&seconds);
srand((unsigned int) seconds);
int shufflecounter = (rand() % 52);
int randcard1 = 0;
int randcard2 = 0;
string temp;

for (;
{
randcard1 = (rand() % 52);
randcard2 = (rand() % 52);
temp = shuffleddeck[randcard1];
shuffleddeck[randcard1] = shuffleddeck[randcard2];
shuffleddeck[randcard2] = temp;
shufflecounter++;
if (shufflecounter==1000)
break;
}
}
void deal()
{
int fullindex=0;
int playerindex=0;

while (playerindex<13)
{
player1[playerindex]=shuffleddeck[fullindex];
playerindex++;
fullindex++;
}
playerindex=0;

while (playerindex<13)
{
player2[playerindex]=shuffleddeck[fullindex];
playerindex++;
fullindex++;
}
playerindex=0;

while (playerindex<13)
{
player3[playerindex]=shuffleddeck[fullindex];
playerindex++;
fullindex++;
}
playerindex=0;

while (playerindex<13)
{
player4[playerindex]=shuffleddeck[fullindex];
playerindex++;
fullindex++;
}
playerindex=0;
}

void board ()
{
int playerindex=0;
cout << "\n \n \n \n \n";
cout << " " << " " << centercard;
cout << "\n \n \n \n \n";
cout << "player1 \n \n";
while (playerindex<11)
{
if (player1[playerindex] != "")
cout << playerindex << ")" << player1[playerindex] << "\t";
if (player1[playerindex+1] != "")
cout << playerindex+1 << ")" <<player1[playerindex+1] << "\t";
if (player1[playerindex+2] != "")
cout << playerindex+2 << ")" <<player1[playerindex+2] << "\n";
playerindex=playerindex+3;
}
if (player1[12] != "")
cout << "12)" << player1[12] << "\t";
cout << "13)" << "pass" << "\n";
p1turn();
}

void p1turn()
{
int temp;
int power;
for (;
{
power=0;
cout << "\n" << "player one enter in the number of the card you want to play \n";
cin >> temp;
if (temp == 13)
{
passer++;
break;
}
if (temp < 0)
continue;
if (temp > 12)
continue;
if (player1[temp]=="")
continue;

while (power < 53)
{
if (fulldeck[power]==player1[temp])
break;
power++;
}
if (powerdeck[power] < powerdeck[centerpower])
continue;
break;
}
if (temp != 13)
{
cout << "player 1 has played the "<< player1[temp] << endl;
centercard=player1[temp];
player1[temp]= "";
centerpower=power;
passer=0;
}
if (passer==4)
{
centercard="none";
centerpower=0;
board ();
}
else wincheck1();
}

void wincheck1()
{
int newgame;
int counter=0;
int check=1;
while (counter < 13)
{
if (player1[counter] != "")
{
check=0;
break;
}
counter++;
}
if (check==1)
{
cout << "\n \n \n" << "player 1 has won! \n \n \n";
cin.get();
exit;
}
else
p2turn();

}
void p2turn()
{
cout << "player 2 turn \n";
int playercounter=0;
int fullcounter=0;
for (;
{
if (fullcounter==52)
{
passer++;
cout << "player 2 passes \n";
break;
}
if (fulldeck[fullcounter]==player2[playercounter] && (powerdeck[fullcounter] > powerdeck[centerpower] || centercard=="none"))
break;
playercounter++;
if (playercounter==13)
{
playercounter=0;
fullcounter++;
}
}
if (fullcounter !=52)
{
cout << "player 2 has played the " << player2[playercounter] << endl;
centercard=player2[playercounter];
player2[playercounter]= "";
centerpower=powerdeck[fullcounter];
passer=0;
cout << centerpower << endl;
}
if (passer==4)
{
centercard="none";
centerpower=0;
board ();
}
wincheck2();
}

void wincheck2()
{
int newgame;
int counter=0;
int check=1;
while (counter < 13)
{
if (player2[counter] != "")
{
check=0;
break;
}
counter++;
}
if (check==1)
{
cout << "\n \n \n" << "computer 2 has won! \n \n \n";
cin.get();
cin.get();
exit;
}
else
p3turn();

}
void p3turn()
{
cout << "player 3 turn \n";
int playercounter=0;
int fullcounter=0;
for (;
{
if (fullcounter==52)
{
passer++;
cout << "player 3 passes \n";
break;
}
if (fulldeck[fullcounter]==player3[playercounter] && (powerdeck[fullcounter] > powerdeck[centerpower] || centercard=="none"))
break;
playercounter++;
if (playercounter==13)
{
playercounter=0;
fullcounter++;
}
}
if (fullcounter !=52)
{
cout << "player 3 has played the " << player3[playercounter] << endl;
centercard=player3[playercounter];
player3[playercounter]= "";
centerpower=powerdeck[fullcounter];
passer=0;
cout << centerpower << endl;
}
if (passer==4)
{
centercard="none";
centerpower=0;
board ();
}
wincheck3();
}
void p4turn()
{
cout << "player 4 turn \n";
int playercounter=0;
int fullcounter=0;
for (;
{
if (fullcounter==52)
{
passer++;
cout << "player 4 passes \n";
break;
}
if (fulldeck[fullcounter]==player4[playercounter] && (powerdeck[fullcounter] > powerdeck[centerpower] || centercard=="none"))
break;
playercounter++;
if (playercounter==13)
{
playercounter=0;
fullcounter++;
}
}
if (fullcounter !=52)
{
cout << "player 4 has played the " << player4[playercounter] << endl;
centercard=player4[playercounter];
player4[playercounter]= "";
centerpower=powerdeck[fullcounter];
passer=0;
cout << centerpower << endl;
}
if (passer==4)
{
centercard="none";
centerpower=0;
board ();
}
wincheck4();
}

void wincheck3()
{
int newgame;
int counter=0;
int check=1;
while (counter < 13)
{
if (player3[counter] != "")
{
check=0;
break;
}
counter++;
}
if (check==1)
{
cout << "\n \n \n" << "computer 3 has won! \n \n \n";
cin.get();
cin.get();
exit;
}
else
p4turn();

}

void wincheck4()
{
int newgame;
int counter=0;
int check=1;
while (counter < 13)
{
if (player4[counter] != "")
{
check=0;
break;
}
counter++;
}
if (check==1)
{
cout << "\n \n \n" << "computer 4 has won! \n \n \n";
cin.get();
cin.get();
exit;
}
else
board();

}
Click to expand...

Log in or Sign up

an error

random guy Private E-2